-
Notifications
You must be signed in to change notification settings - Fork 216
Enhances MSSQL connection with pyodbc support #4335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Enhances MSSQL connection with pyodbc support #4335
Conversation
@erindru hey, I just got around to do this after some onboarding at my new employer. I also had some time to play around with the SQL Database object in fabric, and... I think just adding pyodbc allows us to connect to it like any other mssql. Dare I say it? It feels like it's really close to have some initial Fabric support! 👯 I know, I know, it's not the lakehouse, nor the warehouse objects. But it's something! |
05f43a0
to
249f1f7
Compare
Thanks @mattiasthalen ! Yes we were waiting for Fabric Lakehouse to become a sane product before trying to support Fabric. Interesting to see if this actually works enough to hit the SQL Warehouse endpoint or if there are some Fabric-specific nuances. Can you please add a section to the docs on how to set up Also, can you please rebase onto (if this is still a WIP I can hold off reviewing until it leaves draft status) |
@erindru I tried hitting the Warehouse endpoint, but there are several differences compared to MSSQL that doesn't work the same. E.g., information_schema is case sensitive. Shouldn't be that hard to support it though. I'll probably have a look on that next. Still refreshing to see that the SQL Database object was supported by just being able to login. Ok, I was scratching my head on how to solve those failing tests 😅 Will fix asap and send for review 🎉 |
75522a9
to
58e5f22
Compare
dc299ef
to
c31c2f4
Compare
Co-authored-by: Trey Spiller <[email protected]>
Co-authored-by: Trey Spiller <[email protected]>
c31c2f4
to
064ace9
Compare
Thanks, this is looking pretty good! Just one more thing - there are no tests. Can you please add some tests to test_connection_config that show:
|
Hey sorry for being slow to progress. It's been hectic at work, but I hopens have time this weekend and write the tests |
No problem, there is no expectation / time pressure on community contributions! Thanks for the update |
FYI, Fabric Warehouses can now be created with a case insensitive collation: Create Warehouse with Case Insensitive Collation The new Fabric CLI makes it really easy to create a new Warehouse with this case insensitive collation without messing with the REST APIs. It is possible that your implementation would work with a Warehouse created with a case insensitive collation! |
Adds support for
pyodbc
as an alternative driver for MSSQL connections, providing users with more flexibility and authentication options.driver
option to choose betweenpymssql
andpyodbc
.pyodbc
based on connection parameters.pyodbc
.pyodbc
.